chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc - Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 2083363002: Remove calls to deprecated MessageLoop methods in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

diff --git a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

index 121018b5d96ee35344a7429159ee15cee5e054b9..4c2a58fb7093caf092907852da7b06c3a2b2ae1e 100644

--- a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

+++ b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/stringprintf.h"

#include "base/time/time.h"

#include "chrome/browser/history/history_service_factory.h"

@@ -149,7 +150,7 @@ class BrowserFeatureExtractorTest : public ChromeRenderViewHostTestHarness {

bool ExtractFeatures(ClientPhishingRequest* request) {

StartExtractFeatures(request);

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_EQ(1U, success_.count(request));

return success_.count(request) ? success_[request] : false;

}

@@ -340,7 +341,7 @@ TEST_F(BrowserFeatureExtractorTest, MultipleRequestsAtOnce) {

request2.set_client_score(1.0);

StartExtractFeatures(&request2);

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

EXPECT_TRUE(success_[&request]);

// Success is false because the second URL is not in the history and we are

// not able to distinguish between a missing URL in the history and an error.