Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208133002: [SVG] Remove "New" prefix from properties implementation. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, Eric Willigers, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, kouhei+svg_chromium.org, dino_apple.com, pdr., rwlbuis
Visibility:
Public.

Description

[SVG] Remove "New" prefix from properties implementation. All old SVGProperties implementations are now all removed. The "New" prefix for distinguishing two implementations are no longer needed. Changes automatically generated from: sed -i 's/NewSVG/SVG/g' `find . -name \*.cpp -or -name \*.h` BUG=349370 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -1832 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAngle.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/svg/SVGAngle.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGAngleTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAngleTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedAngle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedAngle.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedEnumerationBase.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedIntegerOptionalInteger.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedIntegerOptionalInteger.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedLengthList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumber.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumber.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumberList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberOptionalNumber.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberOptionalNumber.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimatedPath.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedPointList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedPreserveAspectRatio.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedRect.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedString.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedTransformList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 8 chunks +26 lines, -26 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGBoolean.h View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGBoolean.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElement.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEnumeration.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGEnumeration.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGInteger.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGInteger.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGIntegerOptionalInteger.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGIntegerOptionalInteger.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLength.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGLengthList.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGLengthList.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGLengthListTearOff.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLengthTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMatrixTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGNumber.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGNumberList.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGNumberList.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGNumberListTearOff.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGNumberOptionalNumber.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGNumberOptionalNumber.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGNumberTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGNumberTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathSeg.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegList.h View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGPathSegList.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegListTearOff.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPoint.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGPoint.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPointList.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPointList.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPointListTearOff.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPointTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPointTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatioTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatioTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRect.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGRect.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGRectTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGRectTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStaticStringList.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGStaticStringList.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGString.h View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGString.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGStringList.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGStringList.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGStringListTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStringListTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransform.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGTransform.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGTransformList.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGTransformList.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTransformListTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTransformListTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformTearOff.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTransformTearOff.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/svg/properties/NewSVGAnimatedProperty.h View 1 chunk +0 lines, -319 lines 0 comments Download
D Source/core/svg/properties/NewSVGAnimatedProperty.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/svg/properties/NewSVGListPropertyHelper.h View 1 chunk +0 lines, -371 lines 0 comments Download
D Source/core/svg/properties/NewSVGListPropertyTearOffHelper.h View 1 chunk +0 lines, -224 lines 0 comments Download
D Source/core/svg/properties/NewSVGProperty.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/svg/properties/NewSVGPropertyTearOff.h View 1 chunk +0 lines, -138 lines 0 comments Download
D Source/core/svg/properties/NewSVGPropertyTearOff.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
A + Source/core/svg/properties/SVGAnimatedProperty.h View 12 chunks +34 lines, -34 lines 0 comments Download
A + Source/core/svg/properties/SVGAnimatedProperty.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/svg/properties/SVGListPropertyHelper.h View 15 chunks +23 lines, -23 lines 0 comments Download
A + Source/core/svg/properties/SVGListPropertyTearOffHelper.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/svg/properties/SVGProperty.h View 4 chunks +14 lines, -14 lines 0 comments Download
A + Source/core/svg/properties/SVGPropertyTearOff.h View 6 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/svg/properties/SVGPropertyTearOff.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 9 months ago (2014-03-21 12:11:38 UTC) #1
haraken
I just sampled several files. rubberstamp LGTM.
6 years, 9 months ago (2014-03-21 12:18:09 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 12:19:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/208133002/1
6 years, 9 months ago (2014-03-21 12:19:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 12:22:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-21 12:22:07 UTC) #6
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-21 12:23:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/208133002/1
6 years, 9 months ago (2014-03-21 12:23:54 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 13:26:20 UTC) #9
Message was sent while issue was closed. 
Change committed as 169737

Powered by Google App Engine
This is Rietveld 408576698