Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, mcasas+watch+vc_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, tracing+reviews_chromium.org, ben+mojo_chromium.org, shaktisahu+watch-blimp_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@0_windows
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang-tidy WaitableEvent refactor (Android side) BUG=612843 TBR=danakj@chromium.org (purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO) Committed: https://crrev.com/77b6ad828b2e428ee448c28f695846b7afa2f43c Cr-Commit-Position: refs/heads/master@{#398388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -56 lines) Patch
M android_webview/browser/aw_form_database_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/test/fake_window.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M base/android/application_status_listener_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/java_handler_thread.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M base/test/test_support_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_input_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_reader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/history_report/data_provider.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/android/history_report/delta_file_service.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/android/history_report/usage_reports_buffer_service.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/android/provider/blocking_ui_thread_async_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_android_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/media/android/browser_surface_view_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/test/nested_message_pump_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/android/audio_android_unittest.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M media/gpu/avda_shared_state.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/message_pump/message_pump_mojo.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/cygprofile/cygprofile_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2039943005 Patch 1

Messages

Total messages: 6 (2 generated)
gab
Self-review lgtm, TBR danakj for mechanical/automated C++ change.
4 years, 6 months ago (2016-06-07 16:31:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041033003/1
4 years, 6 months ago (2016-06-07 18:21:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 21:42:47 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 21:43:50 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/77b6ad828b2e428ee448c28f695846b7afa2f43c
Cr-Commit-Position: refs/heads/master@{#398388}

Powered by Google App Engine
This is Rietveld 408576698