Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: chrome/browser/android/history_report/usage_reports_buffer_service.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/history_report/usage_reports_buffer_service.cc
diff --git a/chrome/browser/android/history_report/usage_reports_buffer_service.cc b/chrome/browser/android/history_report/usage_reports_buffer_service.cc
index a83df10c68b9348d85f634d064189ce79f4fffd7..68eb537363ec40d103dea59dbaf2e79b95a4a217 100644
--- a/chrome/browser/android/history_report/usage_reports_buffer_service.cc
+++ b/chrome/browser/android/history_report/usage_reports_buffer_service.cc
@@ -96,7 +96,8 @@ void UsageReportsBufferService::AddVisit(const std::string& id,
std::unique_ptr<std::vector<UsageReport>>
UsageReportsBufferService::GetUsageReportsBatch(int32_t batch_size) {
std::unique_ptr<std::vector<UsageReport>> result;
- base::WaitableEvent finished(false, false);
+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
// It's ok to pass unretained pointers here because this is a synchronous
// call.
@@ -115,7 +116,8 @@ UsageReportsBufferService::GetUsageReportsBatch(int32_t batch_size) {
void UsageReportsBufferService::Remove(
const std::vector<std::string>& report_ids) {
- base::WaitableEvent finished(false, false);
+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
// It's ok to pass unretained pointers here because this is a synchronous
// call.
@@ -131,7 +133,8 @@ void UsageReportsBufferService::Remove(
}
void UsageReportsBufferService::Clear() {
- base::WaitableEvent finished(false, false);
+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
// It's ok to pass unretained pointers here because this is a synchronous
// call.
@@ -147,7 +150,8 @@ void UsageReportsBufferService::Clear() {
std::string UsageReportsBufferService::Dump() {
std::string dump;
- base::WaitableEvent finished(false, false);
+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
// It's ok to pass unretained pointers here because this is a synchronous
// call.

Powered by Google App Engine
This is Rietveld 408576698