base/trace_event/trace_event_android.cc - Issue 2041033003: clang-tidy WaitableEvent refactor (Android side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_android.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_android.cc

diff --git a/base/trace_event/trace_event_android.cc b/base/trace_event/trace_event_android.cc

index d406d2cafaedaf991424264bc38018f5640abde9..a28c54a8b90f218119f64bcf6aab253fef19beaf 100644

--- a/base/trace_event/trace_event_android.cc

+++ b/base/trace_event/trace_event_android.cc

@@ -128,7 +128,8 @@ void TraceLog::StopATrace() {

// TraceLog::Flush() requires the current thread to have a message loop, but

// this thread called from Java may not have one, so flush in another thread.

Thread end_chrome_tracing_thread("end_chrome_tracing");

- WaitableEvent complete_event(false, false);

+ WaitableEvent complete_event(WaitableEvent::ResetPolicy::AUTOMATIC,

+ WaitableEvent::InitialState::NOT_SIGNALED);

end_chrome_tracing_thread.Start();

end_chrome_tracing_thread.task_runner()->PostTask(

FROM_HERE, base::Bind(&EndChromeTracing, Unretained(this),

« no previous file with comments | « base/test/test_support_android.cc ('k') | blimp/client/feature/compositor/blimp_input_manager.cc » ('j') | no next file with comments »