remoting/client/jni/chromoting_jni_runtime.cc - Issue 2041033003: clang-tidy WaitableEvent refactor (Android side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/chromoting_jni_runtime.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/test/spawned_test_server/spawner_communicator.cc ('k') | sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/jni/chromoting_jni_runtime.cc

diff --git a/remoting/client/jni/chromoting_jni_runtime.cc b/remoting/client/jni/chromoting_jni_runtime.cc

index d1897f1c4d79326b1faf436559d8f0b842e2b74f..75422746939a1773dcb3662972d0099c010cf543 100644

--- a/remoting/client/jni/chromoting_jni_runtime.cc

+++ b/remoting/client/jni/chromoting_jni_runtime.cc

@@ -94,7 +94,9 @@ ChromotingJniRuntime::~ChromotingJniRuntime() {

// The singleton should only ever be destroyed on the main thread.

DCHECK(ui_task_runner()->BelongsToCurrentThread());

- base::WaitableEvent done_event(false, false);

+ base::WaitableEvent done_event(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

network_task_runner()->PostTask(

FROM_HERE, base::Bind(&ChromotingJniRuntime::DetachFromVmAndSignal,

base::Unretained(this), &done_event));