Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2039943005: clang-tidy WaitableEvent refactor (Windows side) (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, rjkroege, extensions-reviews_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, chromoting-reviews_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, miu+watch_chromium.org, fdoray, etienneb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang-tidy WaitableEvent refactor (Windows side) Many PCH errors while running clang-tidy on Windows but still generated a couple fixes. Also some NACL changes per this being the first build with enabled_nacl (had forgotten in Linux change @ https://codereview.chromium.org/2024723002/) BUG=612843 TBR=danakj@chromium.org (purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO) Committed: https://crrev.com/cc1d091abd177e9b57101db16503418cfca07e20 Cr-Commit-Position: refs/heads/master@{#398331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -33 lines) Patch
M chrome/app/chrome_watcher_client_unittest_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/browser_watcher/window_hang_monitor_win_unittest.cc View 5 chunks +13 lines, -5 lines 0 comments Download
M components/mus/common/gpu_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/gpu/gpu_service_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/browser/api/dns/mock_host_resolver_creator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/rendering_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/host_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
gab
TBR=danakj@chromium.org (purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO) ...
4 years, 6 months ago (2016-06-07 15:54:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039943005/1
4 years, 6 months ago (2016-06-07 16:03:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/225829)
4 years, 6 months ago (2016-06-07 16:23:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039943005/1
4 years, 6 months ago (2016-06-07 17:09:42 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 17:56:21 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:58:01 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc1d091abd177e9b57101db16503418cfca07e20
Cr-Commit-Position: refs/heads/master@{#398331}

Powered by Google App Engine
This is Rietveld 408576698