chrome/browser/android/provider/blocking_ui_thread_async_request.cc - Issue 2041033003: clang-tidy WaitableEvent refactor (Android side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/provider/blocking_ui_thread_async_request.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/usage_reports_buffer_service.cc ('k') | chrome/browser/history/android/sqlite_cursor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/provider/blocking_ui_thread_async_request.cc

diff --git a/chrome/browser/android/provider/blocking_ui_thread_async_request.cc b/chrome/browser/android/provider/blocking_ui_thread_async_request.cc

index 4eb9811ed63aa68e8a87b5f1d713d36fe82df0d9..b6d3e653711b7b189c9df170deeb36cecb49e49f 100644

--- a/chrome/browser/android/provider/blocking_ui_thread_async_request.cc

+++ b/chrome/browser/android/provider/blocking_ui_thread_async_request.cc

@@ -5,8 +5,8 @@

#include "chrome/browser/android/provider/blocking_ui_thread_async_request.h"

BlockingUIThreadAsyncRequest::BlockingUIThreadAsyncRequest()

- : request_completed_(false, false) {

+ : request_completed_(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED) {}

void BlockingUIThreadAsyncRequest::RequestCompleted() {

// Currently all our use cases receive their request response in the UI