chrome/browser/android/history_report/data_provider.cc - Issue 2041033003: clang-tidy WaitableEvent refactor (Android side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/data_provider.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/bookmarks/partner_bookmarks_reader.cc ('k') | chrome/browser/android/history_report/delta_file_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/data_provider.cc

diff --git a/chrome/browser/android/history_report/data_provider.cc b/chrome/browser/android/history_report/data_provider.cc

index 7cada3a8342657cb0b75064d5900b8e5c73fcdd1..7fa938bb0a0af756bac02a0b43169d014a6f9f01 100644

--- a/chrome/browser/android/history_report/data_provider.cc

+++ b/chrome/browser/android/history_report/data_provider.cc

@@ -38,7 +38,8 @@ struct Context {

base::CancelableTaskTracker* tracker)

: history_service(hservice),

history_task_tracker(tracker),

- finished(false, false) {}

+ finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED) {}

};

void UpdateUrl(Context* context,

@@ -156,7 +157,8 @@ std::unique_ptr<std::vector<DeltaFileEntryWithData>> DataProvider::Query(

void DataProvider::StartVisitMigrationToUsageBuffer(

UsageReportsBufferService* buffer_service) {

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

buffer_service->Clear();

content::BrowserThread::PostTask(

content::BrowserThread::UI,

@@ -172,7 +174,9 @@ void DataProvider::StartVisitMigrationToUsageBuffer(

void DataProvider::RecreateLog() {

std::vector<std::string> urls;

{

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(

+ base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

std::unique_ptr<history::HistoryDBTask> task =

std::unique_ptr<history::HistoryDBTask>(