chrome/browser/android/history_report/delta_file_service.cc - Issue 2041033003: clang-tidy WaitableEvent refactor (Android side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/history_report/delta_file_service.cc

Issue 2041033003: clang-tidy WaitableEvent refactor (Android side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0_windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/history_report/data_provider.cc ('k') | chrome/browser/android/history_report/usage_reports_buffer_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/history_report/delta_file_service.cc

diff --git a/chrome/browser/android/history_report/delta_file_service.cc b/chrome/browser/android/history_report/delta_file_service.cc

index c542177d628da1cfd08035b3d096243c078992dd..63ba56ac60a4238368ace02b023b082cfb7c4948 100644

--- a/chrome/browser/android/history_report/delta_file_service.cc

+++ b/chrome/browser/android/history_report/delta_file_service.cc

@@ -96,7 +96,8 @@ void DeltaFileService::PageDeleted(const GURL& url) {

int64_t DeltaFileService::Trim(int64_t lower_bound) {

int64_t result;

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();

pool->PostSequencedWorkerTaskWithShutdownBehavior(

worker_pool_token_,

@@ -115,7 +116,8 @@ std::unique_ptr<std::vector<DeltaFileEntryWithData>> DeltaFileService::Query(

int64_t last_seq_no,

int32_t limit) {

std::unique_ptr<std::vector<DeltaFileEntryWithData>> result;

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();

pool->PostSequencedWorkerTaskWithShutdownBehavior(

worker_pool_token_,

@@ -133,7 +135,8 @@ std::unique_ptr<std::vector<DeltaFileEntryWithData>> DeltaFileService::Query(

bool DeltaFileService::Recreate(const std::vector<std::string>& urls) {

bool result = false;

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();

pool->PostSequencedWorkerTaskWithShutdownBehavior(

worker_pool_token_,

@@ -160,7 +163,8 @@ void DeltaFileService::Clear() {

std::string DeltaFileService::Dump() {

std::string dump;

- base::WaitableEvent finished(false, false);

+ base::WaitableEvent finished(base::WaitableEvent::ResetPolicy::AUTOMATIC,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();

pool->PostSequencedWorkerTaskWithShutdownBehavior(

worker_pool_token_,