Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
mef
CC:
cbentzel+watch_chromium.org, chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02 Cr-Commit-Position: refs/heads/master@{#397793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M net/base/address_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate_net_log_param.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_request_headers.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_response_headers.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_session.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-03 04:36:59 UTC) #2
mef
lgtm
4 years, 6 months ago (2016-06-03 19:46:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037933002/1
4 years, 6 months ago (2016-06-03 20:20:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 20:26:19 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 20:28:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfec07b7ec31636c9c160434d203ec40899e7f02
Cr-Commit-Position: refs/heads/master@{#397793}

Powered by Google App Engine
This is Rietveld 408576698