Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: net/cert/x509_certificate_net_log_param.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/address_list.cc ('k') | net/dns/dns_config_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate_net_log_param.cc
diff --git a/net/cert/x509_certificate_net_log_param.cc b/net/cert/x509_certificate_net_log_param.cc
index 801712a9bd8341900a5b581cead2a3687358c13e..b056388eb08e29e71a097004625a6180412014b4 100644
--- a/net/cert/x509_certificate_net_log_param.cc
+++ b/net/cert/x509_certificate_net_log_param.cc
@@ -22,7 +22,7 @@ std::unique_ptr<base::Value> NetLogX509CertificateCallback(
std::vector<std::string> encoded_chain;
certificate->GetPEMEncodedChain(&encoded_chain);
for (size_t i = 0; i < encoded_chain.size(); ++i)
- certs->Append(new base::StringValue(encoded_chain[i]));
+ certs->AppendString(encoded_chain[i]);
dict->Set("certificates", std::move(certs));
return std::move(dict);
}
« no previous file with comments | « net/base/address_list.cc ('k') | net/dns/dns_config_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698