Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: net/spdy/spdy_session.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_pool_base.cc ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a9565db39265566325f9b983c17c6cb9911cb69e..3e32f7413dfc91473a70b60842edc9cad16554c4 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -195,11 +195,9 @@ std::unique_ptr<base::Value> NetLogSpdySendSettingsCallback(
const SpdySettingsIds id = it->first;
const SpdySettingsFlags flags = it->second.first;
const uint32_t value = it->second.second;
- settings_list->Append(new base::StringValue(base::StringPrintf(
+ settings_list->AppendString(base::StringPrintf(
"[id:%u flags:%u value:%u]",
- SpdyConstants::SerializeSettingId(protocol_version, id),
- flags,
- value)));
+ SpdyConstants::SerializeSettingId(protocol_version, id), flags, value));
}
dict->Set("settings", std::move(settings_list));
return std::move(dict);
« no previous file with comments | « net/socket/client_socket_pool_base.cc ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698