Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Unified Diff: net/http/http_request_headers.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/dns/dns_config_service.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_request_headers.cc
diff --git a/net/http/http_request_headers.cc b/net/http/http_request_headers.cc
index b04a0b578e09309a4c2158cac2265c3bc83d673d..c6fcaad6366e7facaffb0fdc145460db87a87b89 100644
--- a/net/http/http_request_headers.cc
+++ b/net/http/http_request_headers.cc
@@ -197,9 +197,8 @@ std::unique_ptr<base::Value> HttpRequestHeaders::NetLogCallback(
it != headers_.end(); ++it) {
std::string log_value =
ElideHeaderValueForNetLog(capture_mode, it->key, it->value);
- headers->Append(new base::StringValue(
- base::StringPrintf("%s: %s",
- it->key.c_str(), log_value.c_str())));
+ headers->AppendString(
+ base::StringPrintf("%s: %s", it->key.c_str(), log_value.c_str()));
}
dict->Set("headers", headers);
return std::move(dict);
« no previous file with comments | « net/dns/dns_config_service.cc ('k') | net/http/http_response_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698