net/proxy/proxy_config.cc - Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_config.cc

diff --git a/net/proxy/proxy_config.cc b/net/proxy/proxy_config.cc

index 1ca9ee4292575132ba6ca15de9077c655f3a4e0e..13b0462291e39052afcb79e0fd87b200434af5cb 100644

--- a/net/proxy/proxy_config.cc

+++ b/net/proxy/proxy_config.cc

@@ -281,7 +281,7 @@ std::unique_ptr<base::DictionaryValue> ProxyConfig::ToValue() const {

for (ProxyBypassRules::RuleList::const_iterator it =

bypass.rules().begin();

it != bypass.rules().end(); ++it) {

- list->Append(new base::StringValue((*it)->ToString()));

+ list->AppendString((*it)->ToString());

}

dict->Set("bypass_list", list);

« no previous file with comments | « net/http/transport_security_persister.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »