Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/quic/quic_chromium_client_session.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/quic/quic_connection_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_client_session.cc
diff --git a/net/quic/quic_chromium_client_session.cc b/net/quic/quic_chromium_client_session.cc
index 47d846d47b1472d6d7153cbab2bf9c537bce8458..4cc2864010f576b48a158c0fc8649723ab25c9ed 100644
--- a/net/quic/quic_chromium_client_session.cc
+++ b/net/quic/quic_chromium_client_session.cc
@@ -1037,8 +1037,7 @@ std::unique_ptr<base::Value> QuicChromiumClientSession::GetInfoAsValue(
std::unique_ptr<base::ListValue> stream_list(new base::ListValue());
for (StreamMap::const_iterator it = dynamic_streams().begin();
it != dynamic_streams().end(); ++it) {
- stream_list->Append(
- new base::StringValue(base::UintToString(it->second->id())));
+ stream_list->AppendString(base::UintToString(it->second->id()));
}
dict->Set("active_streams", std::move(stream_list));
@@ -1056,7 +1055,7 @@ std::unique_ptr<base::Value> QuicChromiumClientSession::GetInfoAsValue(
std::unique_ptr<base::ListValue> alias_list(new base::ListValue());
for (std::set<HostPortPair>::const_iterator it = aliases.begin();
it != aliases.end(); it++) {
- alias_list->Append(new base::StringValue(it->ToString()));
+ alias_list->AppendString(it->ToString());
}
dict->Set("aliases", std::move(alias_list));
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/quic/quic_connection_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698