Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: net/dns/dns_config_service.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_net_log_param.cc ('k') | net/http/http_request_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service.cc
diff --git a/net/dns/dns_config_service.cc b/net/dns/dns_config_service.cc
index 9661850f12fbad481db1b086bb910fbd4fed6d71..0f839478a4cea09f087c6ced6c8889eb1f5b0f08 100644
--- a/net/dns/dns_config_service.cc
+++ b/net/dns/dns_config_service.cc
@@ -64,12 +64,12 @@ std::unique_ptr<base::Value> DnsConfig::ToValue() const {
base::ListValue* list = new base::ListValue();
for (size_t i = 0; i < nameservers.size(); ++i)
- list->Append(new base::StringValue(nameservers[i].ToString()));
+ list->AppendString(nameservers[i].ToString());
dict->Set("nameservers", list);
list = new base::ListValue();
for (size_t i = 0; i < search.size(); ++i)
- list->Append(new base::StringValue(search[i]));
+ list->AppendString(search[i]);
dict->Set("search", list);
dict->SetBoolean("unhandled_options", unhandled_options);
« no previous file with comments | « net/cert/x509_certificate_net_log_param.cc ('k') | net/http/http_request_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698