Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 2037933002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_logger.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.cc
diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc
index df27d1566e360fd85c74b68e48986960f896ebfe..8853c1e80305d6fad694f12dbc0b47cb39b7f7de 100644
--- a/net/socket/client_socket_pool_base.cc
+++ b/net/socket/client_socket_pool_base.cc
@@ -623,7 +623,7 @@ ClientSocketPoolBaseHelper::GetInfoAsValue(const std::string& name,
idle_socket != group->idle_sockets().end();
idle_socket++) {
int source_id = idle_socket->socket->NetLog().source().id;
- idle_socket_list->Append(new base::FundamentalValue(source_id));
+ idle_socket_list->AppendInteger(source_id);
}
group_dict->Set("idle_sockets", idle_socket_list);
@@ -631,7 +631,7 @@ ClientSocketPoolBaseHelper::GetInfoAsValue(const std::string& name,
std::list<ConnectJob*>::const_iterator job = group->jobs().begin();
for (job = group->jobs().begin(); job != group->jobs().end(); job++) {
int source_id = (*job)->net_log().source().id;
- connect_jobs_list->Append(new base::FundamentalValue(source_id));
+ connect_jobs_list->AppendInteger(source_id);
}
group_dict->Set("connect_jobs", connect_jobs_list);
« no previous file with comments | « net/quic/quic_connection_logger.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698