Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2037413002: Add SkSourceGammaTreatment enum so we know how to create mips (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new SkSourceGammaTreatment enum, used in situations like mipmap construction, where we need to know if we should respect (vs. ignore) the gamma encoding of sRGB tagged images. Plumb that extensively. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2037413002 Committed: https://skia.googlesource.com/skia/+/982eb7f377a0c771345276558072deb2fcea0d3e

Patch Set 1 #

Patch Set 2 : Remove leftover comments #

Total comments: 1

Patch Set 3 : bool gammaCorrect -> SkSourceGammaTreatment #

Patch Set 4 : Formatting #

Patch Set 5 : Remove extra change that snuck in #

Patch Set 6 : Fix DM compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -150 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M gm/dcshader.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M gm/image_pict.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M include/core/SkImageInfo.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/gpu/SkGr.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkColorFilterShader.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M src/core/SkColorShader.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkColorShader.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkComposeShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkComposeShader.cpp View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkImageCacherator.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 2 4 chunks +11 lines, -7 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 2 5 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/GrImageIDTextureAdjuster.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrImageIDTextureAdjuster.cpp View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.h View 1 2 5 chunks +12 lines, -7 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 2 9 chunks +14 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 5 chunks +17 lines, -9 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImageShader.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/image/SkImage_Base.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/image/SkImage_Generator.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Brian Osman
This is a lot of plumbing. I'm sorry. Perhaps we'll need the flag in other ...
4 years, 6 months ago (2016-06-06 14:58:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037413002/20001
4 years, 6 months ago (2016-06-06 15:02:13 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 15:24:04 UTC) #7
Brian Osman
New version with an enum. We need Mike's change to land so we can connect ...
4 years, 6 months ago (2016-06-06 18:02:04 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037413002/60001
4 years, 6 months ago (2016-06-06 18:04:20 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8927) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 6 months ago (2016-06-06 18:07:31 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037413002/80001
4 years, 6 months ago (2016-06-06 18:16:53 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/3988)
4 years, 6 months ago (2016-06-06 18:22:01 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037413002/100001
4 years, 6 months ago (2016-06-06 18:51:02 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 19:11:03 UTC) #21
bsalomon
lgtm
4 years, 6 months ago (2016-06-06 19:57:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037413002/100001
4 years, 6 months ago (2016-06-06 20:09:33 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:11:06 UTC) #26
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/982eb7f377a0c771345276558072deb2fcea0d3e

Powered by Google App Engine
This is Rietveld 408576698