Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2036013002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a Cr-Commit-Position: refs/heads/master@{#397571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M tools/json_schema_compiler/test/additional_properties_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M tools/json_schema_compiler/test/callbacks_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/test/enums_unittest.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M tools/json_schema_compiler/test/functions_on_types_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/idl_schemas_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/test/objects_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/test/simple_api_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:24:35 UTC) #2
Devlin
lgtm
4 years, 6 months ago (2016-06-02 22:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036013002/1
4 years, 6 months ago (2016-06-02 22:50:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 00:58:04 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 01:00:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3646638f8a49a9cdd4bcecfb9e02b0be8edd260a
Cr-Commit-Position: refs/heads/master@{#397571}

Powered by Google App Engine
This is Rietveld 408576698