Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools

tools/json_schema_compiler/test/objects_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/json/json_writer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/json_schema_compiler/test/objects.h"
 #include "tools/json_schema_compiler/test/objects_movable.h"
 #include "tools/json_schema_compiler/test/objects_movable_json.h"
 
 using namespace test::api::objects;
 using namespace test::api::objects_movable;
 using namespace test::api::objects_movable_json;
 
 TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {
   {
     std::unique_ptr<base::ListValue> strings(new base::ListValue());
-    strings->Append(new base::StringValue("one"));
-    strings->Append(new base::StringValue("two"));
+    strings->AppendString("one");
+    strings->AppendString("two");
     std::unique_ptr<base::DictionaryValue> info_value(
         new base::DictionaryValue());
     info_value->Set("strings", strings.release());
     info_value->Set("integer", new base::FundamentalValue(5));
     info_value->Set("boolean", new base::FundamentalValue(true));
 
     std::unique_ptr<base::ListValue> params_value(new base::ListValue());
     params_value->Append(info_value.release());
     std::unique_ptr<ObjectParam::Params> params(
         ObjectParam::Params::Create(*params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ((size_t) 2, params->info.strings.size());
     EXPECT_EQ("one", params->info.strings[0]);
     EXPECT_EQ("two", params->info.strings[1]);
     EXPECT_EQ(5, params->info.integer);
     EXPECT_TRUE(params->info.boolean);
   }
   {
     std::unique_ptr<base::ListValue> strings(new base::ListValue());
-    strings->Append(new base::StringValue("one"));
-    strings->Append(new base::StringValue("two"));
+    strings->AppendString("one");
+    strings->AppendString("two");
     std::unique_ptr<base::DictionaryValue> info_value(
         new base::DictionaryValue());
     info_value->Set("strings", strings.release());
     info_value->Set("integer", new base::FundamentalValue(5));
 
     std::unique_ptr<base::ListValue> params_value(new base::ListValue());
     params_value->Append(info_value.release());
     std::unique_ptr<ObjectParam::Params> params(
         ObjectParam::Params::Create(*params_value));
     EXPECT_FALSE(params.get());
@@ skipping 99 matching lines @@
   vals2.push_back("vals2a");
   vals2.push_back("vals2b");
   with_additional.additional_properties["key2"] = vals2;
 
   MovableWithAdditional with_additional2(std::move(with_additional));
   EXPECT_EQ("str", with_additional2.str);
   EXPECT_EQ(2u, with_additional2.additional_properties.size());
   EXPECT_EQ(vals1, with_additional2.additional_properties["key1"]);
   EXPECT_EQ(vals2, with_additional2.additional_properties["key2"]);
 }