Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools

tools/json_schema_compiler/test/enums_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/json_schema_compiler/test/enums.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/json_schema_compiler/test/test_util.h"
 
 using namespace test::api::enums;
@@ skipping 12 matching lines @@
     EnumType enum_type;
     base::DictionaryValue value;
     value.Set("type", new base::StringValue("invalid"));
     EXPECT_FALSE(EnumType::Populate(value, &enum_type));
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, EnumsAsTypes) {
   {
     base::ListValue args;
-    args.Append(new base::StringValue("one"));
+    args.AppendString("one");
 
     std::unique_ptr<TakesEnumAsType::Params> params(
         TakesEnumAsType::Params::Create(args));
     ASSERT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_ONE, params->enumeration);
 
     EXPECT_TRUE(args.Equals(ReturnsEnumAsType::Results::Create(
         ENUMERATION_ONE).get()));
   }
   {
@@ skipping 51 matching lines @@
     Enumeration state = ENUMERATION_ONE;
     std::unique_ptr<base::Value> result(new base::StringValue(ToString(state)));
     std::unique_ptr<base::Value> expected(new base::StringValue("one"));
     EXPECT_TRUE(result->Equals(expected.get()));
   }
   {
     Enumeration state = ENUMERATION_ONE;
     std::unique_ptr<base::ListValue> results =
         ReturnsEnum::Results::Create(state);
     base::ListValue expected;
-    expected.Append(new base::StringValue("one"));
+    expected.AppendString("one");
     EXPECT_TRUE(results->Equals(&expected));
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, ReturnsTwoEnumsCreate) {
   {
     std::unique_ptr<base::ListValue> results = ReturnsTwoEnums::Results::Create(
         ENUMERATION_ONE, OTHER_ENUMERATION_HAM);
     base::ListValue expected;
-    expected.Append(new base::StringValue("one"));
-    expected.Append(new base::StringValue("ham"));
+    expected.AppendString("one");
+    expected.AppendString("ham");
     EXPECT_TRUE(results->Equals(&expected));
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, OptionalEnumTypePopulate) {
   {
     OptionalEnumType enum_type;
     base::DictionaryValue value;
     value.Set("type", new base::StringValue("two"));
     EXPECT_TRUE(OptionalEnumType::Populate(value, &enum_type));
@@ skipping 11 matching lines @@
     OptionalEnumType enum_type;
     base::DictionaryValue value;
     value.Set("type", new base::StringValue("invalid"));
     EXPECT_FALSE(OptionalEnumType::Populate(value, &enum_type));
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, TakesEnumParamsCreate) {
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("two"));
+    params_value.AppendString("two");
     std::unique_ptr<TakesEnum::Params> params(
         TakesEnum::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_TWO, params->state);
   }
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("invalid"));
+    params_value.AppendString("invalid");
     std::unique_ptr<TakesEnum::Params> params(
         TakesEnum::Params::Create(params_value));
     EXPECT_FALSE(params.get());
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, TakesEnumArrayParamsCreate) {
   {
     base::ListValue params_value;
     params_value.Append(List(new base::StringValue("one"),
@@ skipping 10 matching lines @@
     params_value.Append(List(new base::StringValue("invalid")).release());
     std::unique_ptr<TakesEnumArray::Params> params(
         TakesEnumArray::Params::Create(params_value));
     EXPECT_FALSE(params);
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, TakesOptionalEnumParamsCreate) {
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("three"));
+    params_value.AppendString("three");
     std::unique_ptr<TakesOptionalEnum::Params> params(
         TakesOptionalEnum::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_THREE, params->state);
   }
   {
     base::ListValue params_value;
     std::unique_ptr<TakesOptionalEnum::Params> params(
         TakesOptionalEnum::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_NONE, params->state);
   }
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("invalid"));
+    params_value.AppendString("invalid");
     std::unique_ptr<TakesOptionalEnum::Params> params(
         TakesOptionalEnum::Params::Create(params_value));
     EXPECT_FALSE(params.get());
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, TakesMultipleOptionalEnumsParamsCreate) {
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("one"));
-    params_value.Append(new base::StringValue("ham"));
+    params_value.AppendString("one");
+    params_value.AppendString("ham");
     std::unique_ptr<TakesMultipleOptionalEnums::Params> params(
         TakesMultipleOptionalEnums::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_ONE, params->state);
     EXPECT_EQ(OTHER_ENUMERATION_HAM, params->type);
   }
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("one"));
+    params_value.AppendString("one");
     std::unique_ptr<TakesMultipleOptionalEnums::Params> params(
         TakesMultipleOptionalEnums::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_ONE, params->state);
     EXPECT_EQ(OTHER_ENUMERATION_NONE, params->type);
   }
   {
     base::ListValue params_value;
     std::unique_ptr<TakesMultipleOptionalEnums::Params> params(
         TakesMultipleOptionalEnums::Params::Create(params_value));
     EXPECT_TRUE(params.get());
     EXPECT_EQ(ENUMERATION_NONE, params->state);
     EXPECT_EQ(OTHER_ENUMERATION_NONE, params->type);
   }
   {
     base::ListValue params_value;
-    params_value.Append(new base::StringValue("three"));
-    params_value.Append(new base::StringValue("invalid"));
+    params_value.AppendString("three");
+    params_value.AppendString("invalid");
     std::unique_ptr<TakesMultipleOptionalEnums::Params> params(
         TakesMultipleOptionalEnums::Params::Create(params_value));
     EXPECT_FALSE(params.get());
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, OnEnumFiredCreate) {
   {
     Enumeration some_enum = ENUMERATION_ONE;
     std::unique_ptr<base::Value> result(
         new base::StringValue(ToString(some_enum)));
     std::unique_ptr<base::Value> expected(new base::StringValue("one"));
     EXPECT_TRUE(result->Equals(expected.get()));
   }
   {
     Enumeration some_enum = ENUMERATION_ONE;
     std::unique_ptr<base::ListValue> results(OnEnumFired::Create(some_enum));
     base::ListValue expected;
-    expected.Append(new base::StringValue("one"));
+    expected.AppendString("one");
     EXPECT_TRUE(results->Equals(&expected));
   }
 }
 
 TEST(JsonSchemaCompilerEnumsTest, OnTwoEnumsFiredCreate) {
   {
     std::unique_ptr<base::Value> results(
         OnTwoEnumsFired::Create(ENUMERATION_ONE, OTHER_ENUMERATION_HAM));
     base::ListValue expected;
-    expected.Append(new base::StringValue("one"));
-    expected.Append(new base::StringValue("ham"));
+    expected.AppendString("one");
+    expected.AppendString("ham");
     EXPECT_TRUE(results->Equals(&expected));
   }
 }