Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/json_schema_compiler/test/objects_unittest.cc

Issue 2036013002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/objects_unittest.cc
diff --git a/tools/json_schema_compiler/test/objects_unittest.cc b/tools/json_schema_compiler/test/objects_unittest.cc
index fffaff15d8f9634a550a8ff2c6d41549aa35629b..14b63464dcfcd7644d72d4340cdfadbd8cdc1539 100644
--- a/tools/json_schema_compiler/test/objects_unittest.cc
+++ b/tools/json_schema_compiler/test/objects_unittest.cc
@@ -17,8 +17,8 @@ using namespace test::api::objects_movable_json;
TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {
{
std::unique_ptr<base::ListValue> strings(new base::ListValue());
- strings->Append(new base::StringValue("one"));
- strings->Append(new base::StringValue("two"));
+ strings->AppendString("one");
+ strings->AppendString("two");
std::unique_ptr<base::DictionaryValue> info_value(
new base::DictionaryValue());
info_value->Set("strings", strings.release());
@@ -38,8 +38,8 @@ TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {
}
{
std::unique_ptr<base::ListValue> strings(new base::ListValue());
- strings->Append(new base::StringValue("one"));
- strings->Append(new base::StringValue("two"));
+ strings->AppendString("one");
+ strings->AppendString("two");
std::unique_ptr<base::DictionaryValue> info_value(
new base::DictionaryValue());
info_value->Set("strings", strings.release());
« no previous file with comments | « tools/json_schema_compiler/test/idl_schemas_unittest.cc ('k') | tools/json_schema_compiler/test/simple_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698