Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tools/json_schema_compiler/test/choices_unittest.cc

Issue 2036013002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/choices_unittest.cc
diff --git a/tools/json_schema_compiler/test/choices_unittest.cc b/tools/json_schema_compiler/test/choices_unittest.cc
index 608ece981f1a294cf6ab7d3dc6c6ffac93112d53..e96268d54f60f50e53ad9f5fd32eae96ec22a14c 100644
--- a/tools/json_schema_compiler/test/choices_unittest.cc
+++ b/tools/json_schema_compiler/test/choices_unittest.cc
@@ -115,7 +115,7 @@ TEST(JsonSchemaCompilerChoicesTest, PopulateChoiceType) {
base::ListValue* strings_value = new base::ListValue();
for (size_t i = 0; i < strings.size(); ++i)
- strings_value->Append(new base::StringValue(strings[i]));
+ strings_value->AppendString(strings[i]);
base::DictionaryValue value;
value.SetInteger("integers", 4);
@@ -134,9 +134,9 @@ TEST(JsonSchemaCompilerChoicesTest, PopulateChoiceType) {
TEST(JsonSchemaCompilerChoicesTest, ChoiceTypeToValue) {
base::ListValue* strings_value = new base::ListValue();
- strings_value->Append(new base::StringValue("list"));
- strings_value->Append(new base::StringValue("of"));
- strings_value->Append(new base::StringValue("strings"));
+ strings_value->AppendString("list");
+ strings_value->AppendString("of");
+ strings_value->AppendString("strings");
base::DictionaryValue value;
value.SetInteger("integers", 5);
« no previous file with comments | « tools/json_schema_compiler/test/callbacks_unittest.cc ('k') | tools/json_schema_compiler/test/enums_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698