Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools

tools/json_schema_compiler/test/idl_schemas_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 #include "tools/json_schema_compiler/test/idl_basics.h"
 #include "tools/json_schema_compiler/test/idl_object_types.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 19 matching lines @@
   a.x = 5;
   a.y = std::string("foo");
   std::unique_ptr<base::DictionaryValue> serialized = a.ToValue();
   MyType1 b;
   EXPECT_TRUE(MyType1::Populate(*serialized.get(), &b));
   EXPECT_EQ(a.x, b.x);
   EXPECT_EQ(a.y, b.y);
 
   // Test Function2, which takes an integer parameter.
   base::ListValue list;
-  list.Append(new base::FundamentalValue(5));
+  list.AppendInteger(5);
   std::unique_ptr<Function2::Params> f2_params =
       Function2::Params::Create(list);
   EXPECT_EQ(5, f2_params->x);
 
   // Test Function3, which takes a MyType1 parameter.
   list.Clear();
   base::DictionaryValue* tmp = new base::DictionaryValue();
   tmp->SetInteger("x", 17);
   tmp->SetString("y", "hello");
   tmp->SetString("z", "zstring");
@@ skipping 26 matching lines @@
   EXPECT_EQ(a.y, c.y);
 }
 
 TEST(IdlCompiler, OptionalArguments) {
   // Test a function that takes one optional argument, both without and with
   // that argument.
   base::ListValue list;
   std::unique_ptr<Function7::Params> f7_params =
       Function7::Params::Create(list);
   EXPECT_EQ(NULL, f7_params->arg.get());
-  list.Append(new base::FundamentalValue(7));
+  list.AppendInteger(7);
   f7_params = Function7::Params::Create(list);
   EXPECT_EQ(7, *(f7_params->arg));
 
   // Similar to above, but a function with one required and one optional
   // argument.
   list.Clear();
-  list.Append(new base::FundamentalValue(8));
+  list.AppendInteger(8);
   std::unique_ptr<Function8::Params> f8_params =
       Function8::Params::Create(list);
   EXPECT_EQ(8, f8_params->arg1);
   EXPECT_EQ(NULL, f8_params->arg2.get());
-  list.Append(new base::StringValue("foo"));
+  list.AppendString("foo");
   f8_params = Function8::Params::Create(list);
   EXPECT_EQ(8, f8_params->arg1);
   EXPECT_EQ("foo", *(f8_params->arg2));
 
   // Test a function with an optional argument of custom type.
   list.Clear();
   std::unique_ptr<Function9::Params> f9_params =
       Function9::Params::Create(list);
   EXPECT_EQ(NULL, f9_params->arg.get());
   list.Clear();
   base::DictionaryValue* tmp = new base::DictionaryValue();
   tmp->SetInteger("x", 17);
   tmp->SetString("y", "hello");
   tmp->SetString("z", "zstring");
   tmp->SetString("a", "astring");
   tmp->SetString("b", "bstring");
   tmp->SetString("c", "cstring");
   list.Append(tmp);
   f9_params = Function9::Params::Create(list);
   ASSERT_TRUE(f9_params->arg.get() != NULL);
   MyType1* t1 = f9_params->arg.get();
   EXPECT_EQ(17, t1->x);
   EXPECT_EQ("hello", t1->y);
 }
 
 TEST(IdlCompiler, ArrayTypes) {
   // Tests of a function that takes an integer and an array of integers. First
   // use an empty array.
   base::ListValue list;
-  list.Append(new base::FundamentalValue(33));
+  list.AppendInteger(33);
   list.Append(new base::ListValue);
   std::unique_ptr<Function10::Params> f10_params =
       Function10::Params::Create(list);
   ASSERT_TRUE(f10_params != NULL);
   EXPECT_EQ(33, f10_params->x);
   EXPECT_TRUE(f10_params->y.empty());
 
   // Same function, but this time with 2 values in the array.
   list.Clear();
-  list.Append(new base::FundamentalValue(33));
+  list.AppendInteger(33);
   base::ListValue* sublist = new base::ListValue;
-  sublist->Append(new base::FundamentalValue(34));
-  sublist->Append(new base::FundamentalValue(35));
+  sublist->AppendInteger(34);
+  sublist->AppendInteger(35);
   list.Append(sublist);
   f10_params = Function10::Params::Create(list);
   ASSERT_TRUE(f10_params != NULL);
   EXPECT_EQ(33, f10_params->x);
   ASSERT_EQ(2u, f10_params->y.size());
   EXPECT_EQ(34, f10_params->y[0]);
   EXPECT_EQ(35, f10_params->y[1]);
 
   // Now test a function which takes an array of a defined type.
   list.Clear();
@@ skipping 45 matching lines @@
                                                       &icon));
   base::ListValue list;
   list.Append(icon_props.release());
   std::unique_ptr<ObjectFunction1::Params> params =
       ObjectFunction1::Params::Create(list);
   ASSERT_TRUE(params.get() != NULL);
   std::string tmp;
   EXPECT_TRUE(params->icon.additional_properties.GetString("hello", &tmp));
   EXPECT_EQ("world", tmp);
 }