Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools

tools/json_schema_compiler/test/choices_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/json_schema_compiler/test/choices.h"
 
 #include <stddef.h>
 
 #include "base/strings/string_piece.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 97 matching lines @@
   }
 }
 
 TEST(JsonSchemaCompilerChoicesTest, PopulateChoiceType) {
   std::vector<std::string> strings = Vector(std::string("list"),
                                             std::string("of"),
                                             std::string("strings"));
 
   base::ListValue* strings_value = new base::ListValue();
   for (size_t i = 0; i < strings.size(); ++i)
-    strings_value->Append(new base::StringValue(strings[i]));
+    strings_value->AppendString(strings[i]);
 
   base::DictionaryValue value;
   value.SetInteger("integers", 4);
   value.Set("strings", strings_value);
 
   ChoiceType out;
   ASSERT_TRUE(ChoiceType::Populate(value, &out));
   ASSERT_TRUE(out.integers.as_integer.get());
   EXPECT_FALSE(out.integers.as_integers.get());
   EXPECT_EQ(4, *out.integers.as_integer);
 
   EXPECT_FALSE(out.strings->as_string.get());
   ASSERT_TRUE(out.strings->as_strings.get());
   EXPECT_EQ(strings, *out.strings->as_strings);
 }
 
 TEST(JsonSchemaCompilerChoicesTest, ChoiceTypeToValue) {
   base::ListValue* strings_value = new base::ListValue();
-  strings_value->Append(new base::StringValue("list"));
-  strings_value->Append(new base::StringValue("of"));
-  strings_value->Append(new base::StringValue("strings"));
+  strings_value->AppendString("list");
+  strings_value->AppendString("of");
+  strings_value->AppendString("strings");
 
   base::DictionaryValue value;
   value.SetInteger("integers", 5);
   value.Set("strings", strings_value);
 
   ChoiceType out;
   ASSERT_TRUE(ChoiceType::Populate(value, &out));
 
   EXPECT_TRUE(value.Equals(out.ToValue().get()));
 }
@@ skipping 139 matching lines @@
           obj->as_choice2->as_choice_types.get();
       // Bleh too much effort to test everything.
       ASSERT_EQ(2u, choice_types->size());
     }
 
     EXPECT_TRUE(base::Value::Equals(value.get(), obj->ToValue().get()));
   }
 }
 
 }  // namespace