Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/json_schema_compiler/test/callbacks_unittest.cc

Issue 2036013002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/callbacks_unittest.cc
diff --git a/tools/json_schema_compiler/test/callbacks_unittest.cc b/tools/json_schema_compiler/test/callbacks_unittest.cc
index f213bb84b5b3845b4db26183b3bb5ad18b12aaab..76cbf963ce0bea40a0a74b49330c0a20d1e80fe1 100644
--- a/tools/json_schema_compiler/test/callbacks_unittest.cc
+++ b/tools/json_schema_compiler/test/callbacks_unittest.cc
@@ -30,7 +30,7 @@ TEST(JsonSchemaCompilerCallbacksTest, ReturnsMultipleResultCreate) {
base::DictionaryValue* expected_dict = new base::DictionaryValue();
expected_dict->SetString("state", "foo");
base::ListValue expected;
- expected.Append(new base::FundamentalValue(5));
+ expected.AppendInteger(5);
expected.Append(expected_dict);
EXPECT_TRUE(results->Equals(&expected));
}
« no previous file with comments | « tools/json_schema_compiler/test/arrays_unittest.cc ('k') | tools/json_schema_compiler/test/choices_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698