Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
eustas, vsevik, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [JSDoc] Fix function bind()-ing against their @this annotations R=vsevik@chromium.org, aandrey, eustas, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169433

Patch Set 1 #

Total comments: 11

Patch Set 2 : Remove unneeded code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -99 lines) Patch
M Source/devtools/front_end/ApplicationCacheItemsView.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ApplicationCacheModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/AuditRules.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/BreakpointManager.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/BreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CanvasProfileView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ContentProviderBasedProjectDelegate.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ContentProviders.js View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/Database.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/DebuggerModel.js View 6 chunks +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ExtensionAPI.js View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/FileSystemModel.js View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/FileSystemProjectDelegate.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/HandlerRegistry.js View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotDataGrids.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotView.js View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/devtools/front_end/InplaceEditor.js View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/IsolatedFileSystem.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ObjectPropertiesSection.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ProfilesPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Script.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/SourceMap.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/SourcesSearchScope.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/StatusBarButton.js View 1 3 chunks +4 lines, -7 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/TempFile.js View 1 8 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apavlov
6 years, 9 months ago (2014-03-18 09:07:41 UTC) #1
vsevik
lgtm
6 years, 9 months ago (2014-03-18 09:40:09 UTC) #2
apavlov
Committed patchset #2 manually as r169433 (presubmit successful).
6 years, 9 months ago (2014-03-18 09:42:26 UTC) #3
aandrey
6 years, 9 months ago (2014-03-18 09:50:07 UTC) #4
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Ap...
File Source/devtools/front_end/ApplicationCacheItemsView.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Ap...
Source/devtools/front_end/ApplicationCacheItemsView.js:221: case 0: comparator =
localeCompare.bind(null, "name"); break;
nit: "switch" and "case" should have same indent

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/CP...
File Source/devtools/front_end/CPUProfileView.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/CP...
Source/devtools/front_end/CPUProfileView.js:937:
WebInspector.console.log("Failed to open temp file with heap snapshot",
nit: WebInspector.console.showErrorMessage()

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Co...
File Source/devtools/front_end/ConsoleViewMessage.js (left):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Co...
Source/devtools/front_end/ConsoleViewMessage.js:698: * @this
{WebInspector.ConsoleViewMessage}
will this also be auto checked by your tool?

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Fi...
File Source/devtools/front_end/FileSystemProjectDelegate.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Fi...
Source/devtools/front_end/FileSystemProjectDelegate.js:239:
matchFileQueries.call(null, result);
matchFileQueries(result);

maybe also add a mini check: func.call(null, ...) -> func(...)

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/He...
File Source/devtools/front_end/HeapSnapshotView.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/He...
Source/devtools/front_end/HeapSnapshotView.js:885:
WebInspector.console.log("Cannot find corresponding heap snapshot node",
WebInspector.ConsoleMessage.MessageLevel.Error, true);
nit: WebInspector.console.showErrorMessage

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Sc...
File Source/devtools/front_end/Script.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Sc...
Source/devtools/front_end/Script.js:145: } else
nit: "{" and "}"

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/St...
File Source/devtools/front_end/StatusBarButton.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/St...
Source/devtools/front_end/StatusBarButton.js:367: var mouseUpListener = mouseUp;
remove this var

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/St...
Source/devtools/front_end/StatusBarButton.js:388: var boundMouseOver =
mouseOver;
remove these two

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempFile.js (right):

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:91: WebInspector.console.log("Failed to
truncate temp file " + e.code + " : " + e.message,
showErrorMessage

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:113: var boundErrorHandler = errorHandler;
remove this var

https://codereview.chromium.org/202623004/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:202: WebInspector.console.log("Failed to
load temp file: " + error.message,
showErrorMessage

Powered by Google App Engine
This is Rietveld 408576698