Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotDataGrids.js ('k') | Source/devtools/front_end/InplaceEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/HeapSnapshotView.js b/Source/devtools/front_end/HeapSnapshotView.js
index 562079b697e2723bedcbfc05a58ac5d933bf70d6..0b1b69e4008c949b652ad918e4ac65ec032b1622 100644
--- a/Source/devtools/front_end/HeapSnapshotView.js
+++ b/Source/devtools/front_end/HeapSnapshotView.js
@@ -869,19 +869,21 @@ WebInspector.HeapSnapshotView.prototype = {
*/
highlightLiveObject: function(perspectiveName, snapshotObjectId)
{
+ this._changePerspectiveAndWait(perspectiveName, didChangePerspective.bind(this));
+
/**
* @this {WebInspector.HeapSnapshotView}
*/
function didChangePerspective()
{
- function didHighlightObject(found)
- {
- if (!found)
- WebInspector.console.log("Cannot find corresponding heap snapshot node", WebInspector.ConsoleMessage.MessageLevel.Error, true);
- }
- this._dataGrid.highlightObjectByHeapSnapshotId(snapshotObjectId, didHighlightObject.bind(this));
+ this._dataGrid.highlightObjectByHeapSnapshotId(snapshotObjectId, didHighlightObject);
+ }
+
+ function didHighlightObject(found)
+ {
+ if (!found)
+ WebInspector.console.log("Cannot find corresponding heap snapshot node", WebInspector.ConsoleMessage.MessageLevel.Error, true);
}
- this._changePerspectiveAndWait(perspectiveName, didChangePerspective.bind(this));
},
_getHoverAnchor: function(target)
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotDataGrids.js ('k') | Source/devtools/front_end/InplaceEditor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698