Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: Source/devtools/front_end/InplaceEditor.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotView.js ('k') | Source/devtools/front_end/IsolatedFileSystem.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/InplaceEditor.js
diff --git a/Source/devtools/front_end/InplaceEditor.js b/Source/devtools/front_end/InplaceEditor.js
index 655ea88a31a89c8e912a989fe66f82a82e0e323d..d0e1c363e1cdeb36157e5442267dac7e83956d12 100644
--- a/Source/devtools/front_end/InplaceEditor.js
+++ b/Source/devtools/front_end/InplaceEditor.js
@@ -114,7 +114,6 @@ WebInspector.InplaceEditor.prototype = {
editingCommitted.call(element);
}
- /** @this {Element} */
function cleanUpAfterEditing()
{
WebInspector.markBeingEdited(element, false);
@@ -132,14 +131,14 @@ WebInspector.InplaceEditor.prototype = {
function editingCancelled()
{
self.cancelEditing(editingContext);
- cleanUpAfterEditing.call(this);
+ cleanUpAfterEditing();
cancelledCallback(this, context);
}
/** @this {Element} */
function editingCommitted()
{
- cleanUpAfterEditing.call(this);
+ cleanUpAfterEditing();
committedCallback(this, self.editorContent(editingContext), editingContext.oldText, context, moveDirection);
}
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotView.js ('k') | Source/devtools/front_end/IsolatedFileSystem.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698