Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: Source/devtools/front_end/DebuggerModel.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/Database.js ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/DebuggerModel.js
diff --git a/Source/devtools/front_end/DebuggerModel.js b/Source/devtools/front_end/DebuggerModel.js
index 67e47e721a32ca6fe0004f0a9a89c5c6492781bc..7e426481bec9c3d4f34af88c99c3ff66c6613fed 100644
--- a/Source/devtools/front_end/DebuggerModel.js
+++ b/Source/devtools/front_end/DebuggerModel.js
@@ -303,7 +303,6 @@ WebInspector.DebuggerModel.prototype = {
* @param {?Protocol.Error} error
* @param {!DebuggerAgent.BreakpointId} breakpointId
* @param {!Array.<!DebuggerAgent.Location>} locations
- * @this {WebInspector.DebuggerModel}
*/
function didSetBreakpoint(error, breakpointId, locations)
{
@@ -312,7 +311,7 @@ WebInspector.DebuggerModel.prototype = {
callback(error ? null : breakpointId, rawLocations);
}
}
- this._agent.setBreakpointByUrl(lineNumber, url, undefined, columnNumber, condition, undefined, didSetBreakpoint.bind(this));
+ this._agent.setBreakpointByUrl(lineNumber, url, undefined, columnNumber, condition, undefined, didSetBreakpoint);
WebInspector.userMetrics.ScriptsBreakpointSet.record();
},
@@ -327,7 +326,6 @@ WebInspector.DebuggerModel.prototype = {
* @param {?Protocol.Error} error
* @param {!DebuggerAgent.BreakpointId} breakpointId
* @param {!DebuggerAgent.Location} actualLocation
- * @this {WebInspector.DebuggerModel}
*/
function didSetBreakpoint(error, breakpointId, actualLocation)
{
@@ -336,7 +334,7 @@ WebInspector.DebuggerModel.prototype = {
callback(error ? null : breakpointId, [rawLocation]);
}
}
- this._agent.setBreakpoint(rawLocation, condition, didSetBreakpoint.bind(this));
+ this._agent.setBreakpoint(rawLocation, condition, didSetBreakpoint);
WebInspector.userMetrics.ScriptsBreakpointSet.record();
},
@@ -942,7 +940,6 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
* @param {?Protocol.Error} error
* @param {!RuntimeAgent.RemoteObject} result
* @param {boolean=} wasThrown
- * @this {WebInspector.DebuggerModel.CallFrame}
*/
function didEvaluateOnCallFrame(error, result, wasThrown)
{
@@ -953,7 +950,7 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
}
callback(result, wasThrown);
}
- this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluateOnCallFrame.bind(this));
+ this._debuggerAgent.evaluateOnCallFrame(this._payload.callFrameId, code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluateOnCallFrame);
},
/**
« no previous file with comments | « Source/devtools/front_end/Database.js ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698