Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: Source/devtools/front_end/ApplicationCacheItemsView.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/ApplicationCacheModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ApplicationCacheItemsView.js
diff --git a/Source/devtools/front_end/ApplicationCacheItemsView.js b/Source/devtools/front_end/ApplicationCacheItemsView.js
index 2b8eabe385a462626e994529633732db7ff01bff..9f88b752063ced8445918dacec78dd4712f24c15 100644
--- a/Source/devtools/front_end/ApplicationCacheItemsView.js
+++ b/Source/devtools/front_end/ApplicationCacheItemsView.js
@@ -218,10 +218,10 @@ WebInspector.ApplicationCacheItemsView.prototype = {
var comparator;
switch (parseInt(this._dataGrid.sortColumnIdentifier(), 10)) {
- case 0: comparator = localeCompare.bind(this, "name"); break;
- case 1: comparator = localeCompare.bind(this, "type"); break;
- case 2: comparator = numberCompare.bind(this, "size"); break;
- default: localeCompare.bind(this, "resource"); // FIXME: comparator = ?
+ case 0: comparator = localeCompare.bind(null, "name"); break;
+ case 1: comparator = localeCompare.bind(null, "type"); break;
+ case 2: comparator = numberCompare.bind(null, "size"); break;
+ default: localeCompare.bind(null, "resource"); // FIXME: comparator = ?
}
this._resources.sort(comparator);
« no previous file with comments | « no previous file | Source/devtools/front_end/ApplicationCacheModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698