Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: Source/devtools/front_end/ElementsTreeOutline.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | Source/devtools/front_end/ExtensionAPI.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ElementsTreeOutline.js
diff --git a/Source/devtools/front_end/ElementsTreeOutline.js b/Source/devtools/front_end/ElementsTreeOutline.js
index bce63a9e2546ff1720a8e9f5d22b0693703aa4f8..6afba3adb394b6d93bf3876b6c1525a3d232ce36 100644
--- a/Source/devtools/front_end/ElementsTreeOutline.js
+++ b/Source/devtools/front_end/ElementsTreeOutline.js
@@ -1375,7 +1375,7 @@ WebInspector.ElementsTreeElement.prototype = {
{
// Add attribute-related actions.
var treeElement = this._elementCloseTag ? this.treeOutline.findTreeElement(this._node) : this;
- contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Add attribute" : "Add Attribute"), this._addNewAttribute.bind(treeElement));
+ contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Add attribute" : "Add Attribute"), treeElement._addNewAttribute.bind(treeElement));
var attribute = event.target.enclosingNodeOrSelfWithClass("webkit-html-attribute");
var newAttribute = event.target.enclosingNodeOrSelfWithClass("add-attribute");
@@ -1550,7 +1550,7 @@ WebInspector.ElementsTreeElement.prototype = {
}
}
- config.customFinishHandler = handleKeyDownEvents.bind(this);
+ config.customFinishHandler = handleKeyDownEvents;
this._editing = WebInspector.InplaceEditor.startEditing(attribute, config);
@@ -1605,7 +1605,6 @@ WebInspector.ElementsTreeElement.prototype = {
/**
* @param {?Event} event
- * @this {WebInspector.ElementsTreeElement}
*/
function keyupListener(event)
{
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | Source/devtools/front_end/ExtensionAPI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698