Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: Source/devtools/front_end/StatusBarButton.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded code Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/SourcesSearchScope.js ('k') | Source/devtools/front_end/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/StatusBarButton.js
diff --git a/Source/devtools/front_end/StatusBarButton.js b/Source/devtools/front_end/StatusBarButton.js
index 570b960d30d6b64f52df6e90adaa7d6e462e5e4a..bea00f70ed3723460f511888df231b3971704c91 100644
--- a/Source/devtools/front_end/StatusBarButton.js
+++ b/Source/devtools/front_end/StatusBarButton.js
@@ -364,8 +364,7 @@ WebInspector.StatusBarButton.prototype = {
mainButtonClone.state = this.state;
buttons.push(mainButtonClone);
- var mouseUpListener = mouseUp.bind(this);
- document.documentElement.addEventListener("mouseup", mouseUpListener, false);
+ document.documentElement.addEventListener("mouseup", mouseUp, false);
var optionsGlassPane = new WebInspector.GlassPane();
var optionsBarElement = optionsGlassPane.element.createChild("div", "alternate-status-bar-buttons-bar");
@@ -385,11 +384,9 @@ WebInspector.StatusBarButton.prototype = {
optionsBarElement.style.top = (hostButtonPosition.top - (buttonHeight * (buttons.length - 1))) + "px";
optionsBarElement.style.left = (hostButtonPosition.left + 1) + "px";
- var boundMouseOver = mouseOver.bind(this);
- var boundMouseOut = mouseOut.bind(this);
for (var i = 0; i < buttons.length; ++i) {
- buttons[i].element.addEventListener("mousemove", boundMouseOver, false);
- buttons[i].element.addEventListener("mouseout", boundMouseOut, false);
+ buttons[i].element.addEventListener("mousemove", mouseOver, false);
+ buttons[i].element.addEventListener("mouseout", mouseOut, false);
optionsBarElement.appendChild(buttons[i].element);
}
var hostButtonIndex = topNotBottom ? 0 : buttons.length - 1;
@@ -416,7 +413,7 @@ WebInspector.StatusBarButton.prototype = {
if (e.which !== 1)
return;
optionsGlassPane.dispose();
- document.documentElement.removeEventListener("mouseup", mouseUpListener, false);
+ document.documentElement.removeEventListener("mouseup", mouseUp, false);
for (var i = 0; i < buttons.length; ++i) {
if (buttons[i].element.classList.contains("emulate-active")) {
« no previous file with comments | « Source/devtools/front_end/SourcesSearchScope.js ('k') | Source/devtools/front_end/StylesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698