Source/devtools/front_end/HandlerRegistry.js - Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/HandlerRegistry.js

Issue 202623004: DevTools: [JSDoc] Fix function bind()-ing against their @this annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove unneeded code Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/HandlerRegistry.js

diff --git a/Source/devtools/front_end/HandlerRegistry.js b/Source/devtools/front_end/HandlerRegistry.js

index 827ea42388c43c6ccc5ceca0ce0a5b4014323657..d8c4fffa58b8e3c49c4546a72d53feb1ec3ba7e4 100644

--- a/Source/devtools/front_end/HandlerRegistry.js

+++ b/Source/devtools/front_end/HandlerRegistry.js

@@ -143,7 +143,6 @@ WebInspector.HandlerRegistry.prototype = {

/**

* @param {boolean} forceSaveAs

- * @this {WebInspector.HandlerRegistry}

function save(forceSaveAs)

{

@@ -152,12 +151,12 @@ WebInspector.HandlerRegistry.prototype = {

uiSourceCode.saveToFileSystem(forceSaveAs);

return;

}

- contentProvider.requestContent(doSave.bind(this, forceSaveAs));

+ contentProvider.requestContent(doSave.bind(null, forceSaveAs));

}

contextMenu.appendSeparator();

- contextMenu.appendItem(WebInspector.UIString("Save"), save.bind(this, false));

- contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Save as..." : "Save As..."), save.bind(this, true));

+ contextMenu.appendItem(WebInspector.UIString("Save"), save.bind(null, false));

+ contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Save as..." : "Save As..."), save.bind(null, true));

/**