Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2005463002: Attach YUV420 to RGB converter to GLContext (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Attach YUV420 to RGB converter to GLContext This is less hacky than the global lookup table. Leave the IOSurface-specific parts of the conversion inside GLImageIOSurface. If this converter is needed on other platforms, this will make it easier to reuse. BUG=611551 BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1882953006 Cr-Commit-Position: refs/heads/master@{#387986} (cherry picked from commit dde9e95fb0cd656c952906a630052d560d8a6753) Committed: https://chromium.googlesource.com/chromium/src/+/8c605e03f431ec403cb34578df279856065d9c7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -237 lines) Patch
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_context.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/gl/gl_context_cgl.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 4 chunks +52 lines, -232 lines 0 comments Download
A ui/gl/yuv_to_rgb_converter.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ui/gl/yuv_to_rgb_converter.cc View 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
4 years, 7 months ago (2016-05-20 19:02:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c605e03f431ec403cb34578df279856065d9c7f.

Powered by Google App Engine
This is Rietveld 408576698