Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. Committed: https://crrev.com/94ea03d8c2335dcce97b85cb760a2907a0b5c925 Cr-Commit-Position: refs/heads/master@{#395250}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h View 1 chunk +6 lines, -6 lines 1 comment Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Maybe.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 21 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 31 chunks +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
4 years, 7 months ago (2016-05-21 01:43:07 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2001893002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h File third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h (right): https://codereview.chromium.org/2001893002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h#newcode75 third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h:75: const T* last() const { return m_impl.last(); } ...
4 years, 7 months ago (2016-05-21 01:55:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001893002/1
4 years, 7 months ago (2016-05-21 02:58:19 UTC) #5
pfeldman
> T* last() const { return m_impl.last(); } > .get() ? I know. But it ...
4 years, 7 months ago (2016-05-21 02:58:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 05:37:39 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 05:39:27 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/94ea03d8c2335dcce97b85cb760a2907a0b5c925
Cr-Commit-Position: refs/heads/master@{#395250}

Powered by Google App Engine
This is Rietveld 408576698