DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/.

third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8InjectedScriptHost.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScriptNative.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
@@ skipping 11 matching lines @@
     v8::Local<v8::Function> func;
     if (!v8::Function::New(context, callback, external).ToLocal(&func))
         return;
     func->SetName(funcName);
     if (!obj->Set(context, funcName, func).FromMaybe(false))
         return;
 }
 
 V8DebuggerImpl* unwrapDebugger(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    ASSERT(!info.Data().IsEmpty());
-    ASSERT(info.Data()->IsExternal());
+    DCHECK(!info.Data().IsEmpty());
+    DCHECK(info.Data()->IsExternal());
     V8DebuggerImpl* debugger = static_cast<V8DebuggerImpl*>(info.Data().As<v8::External>()->Value());
-    ASSERT(debugger);
+    DCHECK(debugger);
     return debugger;
 }
 
 } // namespace
 
 v8::Local<v8::Object> V8InjectedScriptHost::create(v8::Local<v8::Context> context, V8DebuggerImpl* debugger)
 {
     v8::Isolate* isolate = debugger->isolate();
     v8::Local<v8::Object> injectedScriptHost = v8::Object::New(isolate);
     v8::Local<v8::External> debuggerExternal = v8::External::New(isolate, debugger);
@@ skipping 145 matching lines @@
         if (!listeners->Length())
             continue;
         result->Set(toV8String(info.GetIsolate(), it.first), listeners);
     }
     info.GetReturnValue().Set(result);
 }
 
 void V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 2 || info.Length() > 3 || !info[0]->IsFunction()) {
-        ASSERT_NOT_REACHED();
+        NOTREACHED();
         return;
     }
     if (info.Length() > 2 && (!info[2]->IsArray() && !info[2]->IsUndefined())) {
-        ASSERT_NOT_REACHED();
+        NOTREACHED();
         return;
     }
 
     v8::Isolate* isolate = info.GetIsolate();
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
 
     v8::Local<v8::Function> function = info[0].As<v8::Function>();
     v8::Local<v8::Value> receiver = info[1];
     OwnPtr<v8::Local<v8::Value>[]> argv = nullptr;
     size_t argc = 0;
@@ skipping 19 matching lines @@
     client->unmuteWarningsAndDeprecations();
 }
 
 void V8InjectedScriptHost::setNonEnumPropertyCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 3 || !info[0]->IsObject() || !info[1]->IsString())
         return;
 
     v8::Local<v8::Object> object = info[0].As<v8::Object>();
     v8::Maybe<bool> success = object->DefineOwnProperty(info.GetIsolate()->GetCurrentContext(), info[1].As<v8::String>(), info[2], v8::DontEnum);
-    ASSERT_UNUSED(!success.IsNothing(), !success.IsNothing());
+    DCHECK(!success.IsNothing());
 }
 
 void V8InjectedScriptHost::bindCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 2 || !info[1]->IsString())
         return;
     InjectedScriptNative* injectedScriptNative = InjectedScriptNative::fromInjectedScriptHost(info.Holder());
     if (!injectedScriptNative)
         return;
 
     v8::Local<v8::String> v8groupName = info[1]->ToString(info.GetIsolate());
     String16 groupName = toProtocolStringWithTypeCheck(v8groupName);
     int id = injectedScriptNative->bind(info[0], groupName);
     info.GetReturnValue().Set(id);
 }
 
 void V8InjectedScriptHost::proxyTargetValueCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() != 1 || !info[0]->IsProxy()) {
-        ASSERT_NOT_REACHED();
+        NOTREACHED();
         return;
     }
     v8::Local<v8::Object> target = info[0].As<v8::Proxy>();
     while (target->IsProxy())
         target = v8::Local<v8::Proxy>::Cast(target)->GetTarget();
     info.GetReturnValue().Set(target);
 }
 
 void V8InjectedScriptHost::prototypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    ASSERT(info.Length() > 0 && info[0]->IsObject());
+    DCHECK(info.Length() > 0 && info[0]->IsObject());
     info.GetReturnValue().Set(info[0].As<v8::Object>()->GetPrototype());
 }
 
 v8::Local<v8::Private> V8Debugger::scopeExtensionPrivate(v8::Isolate* isolate)
 {
     return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8Debugger#scopeExtension"));
 }
 
 } // namespace blink