third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp - Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

index be7bef642cc143bb8456109f3d8ce856d9e5d12a..d4678ab1721eafb403e5d943bda7e825135029b6 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

@@ -69,7 +69,7 @@ int V8Regex::match(const String16& string, int startFrom, int* matchLength) cons

// https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/RegExp/exec

- ASSERT(!returnValue.IsEmpty());

+ DCHECK(!returnValue.IsEmpty());

if (!returnValue->IsArray())

return -1;