Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 { 87 {
88 // TODO(dgozman): get rid of this check. 88 // TODO(dgozman): get rid of this check.
89 if (!m_debugger->client()->isExecutionAllowed()) 89 if (!m_debugger->client()->isExecutionAllowed())
90 return v8::Local<v8::Value>(); 90 return v8::Local<v8::Value>();
91 91
92 v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_value); 92 v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_value);
93 v8::Local<v8::Value> value; 93 v8::Local<v8::Value> value;
94 if (!thisObject->Get(m_context, m_name).ToLocal(&value)) 94 if (!thisObject->Get(m_context, m_name).ToLocal(&value))
95 return v8::Local<v8::Value>(); 95 return v8::Local<v8::Value>();
96 96
97 ASSERT(value->IsFunction()); 97 DCHECK(value->IsFunction());
98 98
99 v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value); 99 v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);
100 OwnPtr<v8::Local<v8::Value>[]> info = adoptArrayPtr(new v8::Local<v8::Value> [m_arguments.size()]); 100 OwnPtr<v8::Local<v8::Value>[]> info = adoptArrayPtr(new v8::Local<v8::Value> [m_arguments.size()]);
101 for (size_t i = 0; i < m_arguments.size(); ++i) { 101 for (size_t i = 0; i < m_arguments.size(); ++i) {
102 info[i] = m_arguments[i]; 102 info[i] = m_arguments[i];
103 ASSERT(!info[i].IsEmpty()); 103 DCHECK(!info[i].IsEmpty());
104 } 104 }
105 105
106 v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), v8::MicrotasksS cope::kDoNotRunMicrotasks); 106 v8::MicrotasksScope microtasksScope(m_context->GetIsolate(), v8::MicrotasksS cope::kDoNotRunMicrotasks);
107 v8::Local<v8::Value> result; 107 v8::Local<v8::Value> result;
108 if (!function->Call(m_context, thisObject, m_arguments.size(), info.get()).T oLocal(&result)) 108 if (!function->Call(m_context, thisObject, m_arguments.size(), info.get()).T oLocal(&result))
109 return v8::Local<v8::Value>(); 109 return v8::Local<v8::Value>();
110 return result; 110 return result;
111 } 111 }
112 112
113 v8::Local<v8::Function> V8FunctionCall::function() 113 v8::Local<v8::Function> V8FunctionCall::function()
114 { 114 {
115 v8::TryCatch tryCatch(m_context->GetIsolate()); 115 v8::TryCatch tryCatch(m_context->GetIsolate());
116 v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_value); 116 v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(m_value);
117 v8::Local<v8::Value> value; 117 v8::Local<v8::Value> value;
118 if (!thisObject->Get(m_context, m_name).ToLocal(&value)) 118 if (!thisObject->Get(m_context, m_name).ToLocal(&value))
119 return v8::Local<v8::Function>(); 119 return v8::Local<v8::Function>();
120 120
121 ASSERT(value->IsFunction()); 121 DCHECK(value->IsFunction());
122 return v8::Local<v8::Function>::Cast(value); 122 return v8::Local<v8::Function>::Cast(value);
123 } 123 }
124 124
125 } // namespace blink 125 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698