Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
index 98dedee37bcf2b2f125880f63cdcb92da1663b57..4a7a0593e03a496068e16024d1a95163e9056ffb 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
@@ -139,7 +139,7 @@ void V8ProfilerAgentImpl::consoleProfile(const String16& title)
{
if (!m_enabled)
return;
- ASSERT(m_frontend);
+ DCHECK(m_frontend);
String16 id = nextProfileId();
m_startedProfiles.append(ProfileDescriptor(id, title));
startProfiling(id);
@@ -150,7 +150,7 @@ void V8ProfilerAgentImpl::consoleProfileEnd(const String16& title)
{
if (!m_enabled)
return;
- ASSERT(m_frontend);
+ DCHECK(m_frontend);
String16 id;
String16 resolvedTitle;
// Take last started profile if no title was passed.
@@ -215,13 +215,13 @@ void V8ProfilerAgentImpl::clearFrontend()
{
ErrorString error;
disable(&error);
- ASSERT(m_frontend);
+ DCHECK(m_frontend);
m_frontend = nullptr;
}
void V8ProfilerAgentImpl::restore()
{
- ASSERT(!m_enabled);
+ DCHECK(!m_enabled);
if (!m_state->booleanProperty(ProfilerAgentState::profilerEnabled, false))
return;
m_enabled = true;

Powered by Google App Engine
This is Rietveld 408576698