DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/.

third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8Console.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/InspectedContext.h"
 #include "platform/v8_inspector/V8Compat.h"
@@ skipping 25 matching lines @@
         , m_isolate(info.GetIsolate())
         , m_context(info.GetIsolate()->GetCurrentContext())
         , m_inspectedContext(nullptr)
         , m_debuggerClient(nullptr)
     {
     }
 
     v8::Local<v8::Object> ensureConsole()
     {
         if (m_console.IsEmpty()) {
-            ASSERT(!m_info.Data().IsEmpty());
-            ASSERT(!m_info.Data()->IsUndefined());
+            DCHECK(!m_info.Data().IsEmpty());
+            DCHECK(!m_info.Data()->IsUndefined());
             m_console = m_info.Data().As<v8::Object>();
         }
         return m_console;
     }
 
     InspectedContext* ensureInspectedContext()
     {
         if (m_inspectedContext)
             return m_inspectedContext;
         v8::Local<v8::Object> console = ensureConsole();
 
         v8::Local<v8::Private> key = inspectedContextPrivateKey(m_isolate);
         v8::Local<v8::Value> inspectedContextValue;
         if (!console->GetPrivate(m_context, key).ToLocal(&inspectedContextValue))
             return nullptr;
-        ASSERT(inspectedContextValue->IsExternal());
+        DCHECK(inspectedContextValue->IsExternal());
         m_inspectedContext = static_cast<InspectedContext*>(inspectedContextValue.As<v8::External>()->Value());
         return m_inspectedContext;
     }
 
     V8DebuggerClient* ensureDebuggerClient()
     {
         if (m_debuggerClient)
             return m_debuggerClient;
         InspectedContext* inspectedContext = ensureInspectedContext();
         if (!inspectedContext)
@@ skipping 148 matching lines @@
     InspectedContext* m_inspectedContext;
     V8DebuggerClient* m_debuggerClient;
 
     bool checkAndSetPrivateFlagOnConsole(const char* name, bool defaultValue)
     {
         v8::Local<v8::Object> console = ensureConsole();
         v8::Local<v8::Private> key = v8::Private::ForApi(m_isolate, toV8StringInternalized(m_isolate, name));
         v8::Local<v8::Value> flagValue;
         if (!console->GetPrivate(m_context, key).ToLocal(&flagValue))
             return defaultValue;
-        ASSERT(flagValue->IsUndefined() || flagValue->IsBoolean());
+        DCHECK(flagValue->IsUndefined() || flagValue->IsBoolean());
         if (flagValue->IsBoolean()) {
-            ASSERT(flagValue.As<v8::Boolean>()->Value());
+            DCHECK(flagValue.As<v8::Boolean>()->Value());
             return true;
         }
         if (!console->SetPrivate(m_context, key, v8::True(m_isolate)).FromMaybe(false))
             return defaultValue;
         return false;
     }
 };
 
 void returnDataCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
@@ skipping 360 matching lines @@
     inspectImpl(info, false);
 }
 
 void V8Console::copyCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     inspectImpl(info, true);
 }
 
 void V8Console::inspectedObject(const v8::FunctionCallbackInfo<v8::Value>& info, unsigned num)
 {
-    ASSERT(num < V8InspectorSessionImpl::kInspectedObjectBufferSize);
+    DCHECK(num < V8InspectorSessionImpl::kInspectedObjectBufferSize);
     ConsoleHelper helper(info);
     if (V8InspectorSessionImpl* session = helper.currentSession()) {
         V8InspectorSession::Inspectable* object = session->inspectedObject(num);
         v8::Isolate* isolate = info.GetIsolate();
         if (object)
             info.GetReturnValue().Set(object->get(isolate->GetCurrentContext()));
         else
             info.GetReturnValue().Set(v8::Undefined(isolate));
     }
 }
@@ skipping 100 matching lines @@
     DEFINE_STATIC_LOCAL(protocol::HashSet<String16>, getters, ());
     if (getters.size() == 0) {
         const char* members[] = { "$0", "$1", "$2", "$3", "$4", "$_" };
         for (size_t i = 0; i < WTF_ARRAY_LENGTH(members); ++i)
             getters.add(members[i]);
     }
     return getters.find(name) != getters.end();
 }
 
 } // namespace blink