Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 350
351 void V8RuntimeAgentImpl::setFrontend(protocol::Frontend::Runtime* frontend) 351 void V8RuntimeAgentImpl::setFrontend(protocol::Frontend::Runtime* frontend)
352 { 352 {
353 m_frontend = frontend; 353 m_frontend = frontend;
354 } 354 }
355 355
356 void V8RuntimeAgentImpl::clearFrontend() 356 void V8RuntimeAgentImpl::clearFrontend()
357 { 357 {
358 ErrorString error; 358 ErrorString error;
359 disable(&error); 359 disable(&error);
360 ASSERT(m_frontend); 360 DCHECK(m_frontend);
361 m_frontend = nullptr; 361 m_frontend = nullptr;
362 } 362 }
363 363
364 void V8RuntimeAgentImpl::restore() 364 void V8RuntimeAgentImpl::restore()
365 { 365 {
366 if (!m_state->booleanProperty(V8RuntimeAgentImplState::runtimeEnabled, false )) 366 if (!m_state->booleanProperty(V8RuntimeAgentImplState::runtimeEnabled, false ))
367 return; 367 return;
368 m_frontend->executionContextsCleared(); 368 m_frontend->executionContextsCleared();
369 ErrorString error; 369 ErrorString error;
370 enable(&error); 370 enable(&error);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 } 428 }
429 } 429 }
430 430
431 void V8RuntimeAgentImpl::inspect(PassOwnPtr<protocol::Runtime::RemoteObject> obj ectToInspect, PassOwnPtr<protocol::DictionaryValue> hints) 431 void V8RuntimeAgentImpl::inspect(PassOwnPtr<protocol::Runtime::RemoteObject> obj ectToInspect, PassOwnPtr<protocol::DictionaryValue> hints)
432 { 432 {
433 if (m_enabled) 433 if (m_enabled)
434 m_frontend->inspectRequested(std::move(objectToInspect), std::move(hints )); 434 m_frontend->inspectRequested(std::move(objectToInspect), std::move(hints ));
435 } 435 }
436 436
437 } // namespace blink 437 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698