Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h b/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h
index 4796b528cc4d98330f0cec7f8c44514ab88ddf10..e2da852c6809880cfadb9cd40765970a47188c6d 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h
+++ b/third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h
@@ -67,12 +67,12 @@ public:
void resize(size_t s) { m_impl.resize(s); }
size_t size() const { return m_impl.size(); }
bool isEmpty() const { return m_impl.isEmpty(); }
- OwnPtr<T>& operator[](size_t i) { return m_impl.at(i); }
- const OwnPtr<T>& operator[](size_t i) const { return m_impl.at(i); }
- OwnPtr<T>& at(size_t i) { return m_impl.at(i); }
- const OwnPtr<T>& at(size_t i) const { return m_impl.at(i); }
- OwnPtr<T>& last() { return m_impl.last(); }
- const OwnPtr<T>& last() const { return m_impl.last(); }
+ T* operator[](size_t i) { return m_impl.at(i).get(); }
+ const T* operator[](size_t i) const { return m_impl.at(i).get(); }
+ T* at(size_t i) { return m_impl.at(i).get(); }
+ const T* at(size_t i) const { return m_impl.at(i).get(); }
+ T* last() { return m_impl.last().get(); }
+ const T* last() const { return m_impl.last(); }
dgozman 2016/05/21 01:55:29 .get() ?
void append(PassOwnPtr<T> t) { m_impl.append(std::move(t)); }
void prepend(PassOwnPtr<T> t) { m_impl.prepend(std::move(t)); }
void remove(size_t i) { m_impl.remove(i); }

Powered by Google App Engine
This is Rietveld 408576698