Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, asanka, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. This patch converts the rest of them. BUG=602523 Committed: https://crrev.com/7286af58181e605f3ba1100f5af3ce74961b6361 Cr-Commit-Position: refs/heads/master@{#394857}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -102 lines) Patch
M chrome/browser/ui/webui/settings/certificates_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/downloads_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/languages_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/native_certificates_handler.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/reset_settings_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/reset_settings_handler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/search_engines_handler.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/search_engines_handler.cc View 1 12 chunks +36 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_default_browser_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_default_browser_handler.cc View 1 3 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.h View 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_page_ui_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_page_ui_handler.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 1 8 chunks +30 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc View 1 2 3 4 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988463002/20001
4 years, 7 months ago (2016-05-17 17:48:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/204873)
4 years, 7 months ago (2016-05-17 18:03:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988463002/40001
4 years, 7 months ago (2016-05-17 18:07:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 19:15:56 UTC) #8
tommycli
dbeam: PTAL more webui JS-safe conversions for Settings. thx
4 years, 7 months ago (2016-05-17 21:35:35 UTC) #10
Dan Beam
so, for all these handlers that you're making override the [now] pure virtual OnJavascript{Allowed,Disallowed}, when ...
4 years, 7 months ago (2016-05-18 00:23:30 UTC) #11
tommycli
https://codereview.chromium.org/1988463002/diff/40001/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc File chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc (right): https://codereview.chromium.org/1988463002/diff/40001/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc#newcode37 chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:37: handler()->HandleGetDefaultValueForContentType(&list_args); On 2016/05/18 00:23:30, Dan Beam wrote: > this ...
4 years, 7 months ago (2016-05-18 21:12:12 UTC) #12
tommycli
A number of these handlers never do C++ -> JS calls. For those, I overrode ...
4 years, 7 months ago (2016-05-18 21:13:42 UTC) #13
Dan Beam
lgtm w/suggestion also, we should add a whole bunch of "Unsafe"s sometime soon ;) https://codereview.chromium.org/1988463002/diff/60001/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h ...
4 years, 7 months ago (2016-05-19 03:36:55 UTC) #14
tommycli
dbeam: thanks! https://codereview.chromium.org/1988463002/diff/60001/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h File chrome/browser/ui/webui/settings/settings_manage_profile_handler.h (right): https://codereview.chromium.org/1988463002/diff/60001/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h#newcode40 chrome/browser/ui/webui/settings/settings_manage_profile_handler.h:40: friend class ManageProfileHandlerTest; On 2016/05/19 03:36:54, Dan ...
4 years, 7 months ago (2016-05-19 19:27:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988463002/80001
4 years, 7 months ago (2016-05-19 19:27:49 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-19 20:49:55 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:52:09 UTC) #21
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/7286af58181e605f3ba1100f5af3ce74961b6361
Cr-Commit-Position: refs/heads/master@{#394857}

Powered by Google App Engine
This is Rietveld 408576698