MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_MANAGE_PROFILE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_MANAGE_PROFILE_HANDLER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 12 matching lines @@
 
 // Chrome personal stuff profiles manage overlay UI handler.
 class ManageProfileHandler : public settings::SettingsPageUIHandler,
                              public ProfileAttributesStorage::Observer {
  public:
   explicit ManageProfileHandler(Profile* profile);
   ~ManageProfileHandler() override;
 
   // settings::SettingsPageUIHandler:
   void RegisterMessages() override;
+  void OnJavascriptAllowed() override;
+  void OnJavascriptDisallowed() override;
 
   // ProfileAttributesStorage::Observer:
   void OnProfileAvatarChanged(const base::FilePath& profile_path) override;
 
  private:
+  friend class ManageProfileHandlerTest;

[Dan Beam, 2016/05/19 03:36:54]

you don't need this if you just raise access to public with my "using" hack in
the test-only version of this class

[tommycli, 2016/05/19 19:27:15]

Done.

   FRIEND_TEST_ALL_PREFIXES(ManageProfileHandlerTest,
                            HandleSetProfileIconAndName);
   FRIEND_TEST_ALL_PREFIXES(ManageProfileHandlerTest, HandleGetAvailableIcons);
 
   // Callback for the "getAvailableIcons" message.
   // Sends the array of default profile icon URLs and profile names to WebUI.
   void HandleGetAvailableIcons(const base::ListValue* args);
 
   // Get all the available profile icons to choose from.
   std::unique_ptr<base::ListValue> GetAvailableIcons();
@@ skipping 37 matching lines @@
 
   // For generating weak pointers to itself for callbacks.
   base::WeakPtrFactory<ManageProfileHandler> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ManageProfileHandler);
 };
 
 }  // namespace settings
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_SETTINGS_MANAGE_PROFILE_HANDLER_H_