Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2880)

Unified Diff: chrome/browser/ui/webui/settings/settings_page_ui_handler.cc

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_page_ui_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc b/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc
index 93326fa23f5a79a271fecb5cc02159c72d733298..abe3557ffb78bd28ddbae9e36407852abb78f347 100644
--- a/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_page_ui_handler.cc
@@ -16,18 +16,16 @@ void SettingsPageUIHandler::ResolveJavascriptCallback(
const base::Value& callback_id,
const base::Value& response) {
// cr.webUIResponse is a global JS function exposed from cr.js.
- web_ui()->CallJavascriptFunction(
- "cr.webUIResponse", callback_id,
- base::FundamentalValue(true), response);
+ CallJavascriptFunction("cr.webUIResponse", callback_id,
+ base::FundamentalValue(true), response);
}
void SettingsPageUIHandler::RejectJavascriptCallback(
const base::Value& callback_id,
const base::Value& response) {
// cr.webUIResponse is a global JS function exposed from cr.js.
- web_ui()->CallJavascriptFunction(
- "cr.webUIResponse", callback_id,
- base::FundamentalValue(false), response);
+ CallJavascriptFunction("cr.webUIResponse", callback_id,
+ base::FundamentalValue(false), response);
}
} // namespace settings
« no previous file with comments | « chrome/browser/ui/webui/settings/settings_page_ui_handler.h ('k') | chrome/browser/ui/webui/settings/site_settings_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698