chrome/browser/ui/webui/settings/site_settings_handler.h - Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler.h

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_page_ui_handler.cc ('k') | chrome/browser/ui/webui/settings/site_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/site_settings_handler.h

diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.h b/chrome/browser/ui/webui/settings/site_settings_handler.h

index b89bf848c9a5e2037f4e285de78f76b3191953f5..4442c50a79f8d5462fe0180e4ea92a29245066c5 100644

--- a/chrome/browser/ui/webui/settings/site_settings_handler.h

+++ b/chrome/browser/ui/webui/settings/site_settings_handler.h

@@ -30,6 +30,8 @@ class SiteSettingsHandler : public SettingsPageUIHandler,

// SettingsPageUIHandler:

void RegisterMessages() override;

+ void OnJavascriptAllowed() override;

+ void OnJavascriptDisallowed() override;

void OnGetUsageInfo(const storage::UsageInfoEntries& entries);

void OnUsageInfoCleared(storage::QuotaStatusCode code);

@@ -40,6 +42,7 @@ class SiteSettingsHandler : public SettingsPageUIHandler,

ContentSettingsType content_type,

std::string resource_identifier) override;

private:

+ friend class SiteSettingsHandlerTest;

FRIEND_TEST_ALL_PREFIXES(SiteSettingsHandlerTest, GetAndSetDefault);

FRIEND_TEST_ALL_PREFIXES(SiteSettingsHandlerTest, Origins);

FRIEND_TEST_ALL_PREFIXES(SiteSettingsHandlerTest, Patterns);