MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_web_ui.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace settings {
 
 namespace {
 
 class TestManageProfileHandler : public ManageProfileHandler {
  public:
   explicit TestManageProfileHandler(Profile* profile)
       : ManageProfileHandler(profile) {}
 
   using ManageProfileHandler::set_web_ui;

[Dan Beam, 2016/05/19 03:36:54]

using ManageProfileHandler::AllowJavascript;

[tommycli, 2016/05/19 19:27:15]

Done.

 };
 
 }  // namespace
 
 class ManageProfileHandlerTest : public testing::Test {
  public:
   ManageProfileHandlerTest()
       : profile_manager_(TestingBrowserProcess::GetGlobal()),
         profile_(nullptr) {}
 
   void SetUp() override {
     ASSERT_TRUE(profile_manager_.SetUp());
     profile_ = profile_manager_.CreateTestingProfile("Profile 1");
 
     handler_.reset(new TestManageProfileHandler(profile_));
     handler_->set_web_ui(&web_ui_);
+    handler()->AllowJavascript();
+    web_ui()->ClearTrackedCalls();
   }
 
   void VerifyIconList(const base::Value* value) {
     const base::ListValue* icon_urls = nullptr;
     ASSERT_TRUE(value->GetAsList(&icon_urls));
 
     // Expect the list of icon URLs to be a non-empty list of non-empty strings.
     EXPECT_FALSE(icon_urls->empty());
     for (size_t i = 0; i < icon_urls->GetSize(); ++i) {
       std::string icon_url;
@@ skipping 56 matching lines @@
   EXPECT_EQ("cr.webUIListenerCallback", data.function_name());
 
   std::string event_id;
   ASSERT_TRUE(data.arg1()->GetAsString(&event_id));
   EXPECT_EQ("available-icons-changed", event_id);
 
   VerifyIconList(data.arg2());
 }
 
 }  // namespace settings