chrome/browser/ui/webui/settings/settings_page_ui_handler.h - Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_page_ui_handler.h

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc ('k') | chrome/browser/ui/webui/settings/settings_page_ui_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_page_ui_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_page_ui_handler.h b/chrome/browser/ui/webui/settings/settings_page_ui_handler.h

index b0cab4116abb81f79da5e5ba6b1a861fe0efe29e..b359130dd9df467c350b6b048981060b0af1d9bd 100644

--- a/chrome/browser/ui/webui/settings/settings_page_ui_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_page_ui_handler.h

@@ -31,6 +31,10 @@ class SettingsPageUIHandler : public content::WebUIMessageHandler {

const base::Value& response);

private:

+ // SettingsPageUIHandler subclasses must be JavaScript-lifecycle safe.

+ void OnJavascriptAllowed() override = 0;

+ void OnJavascriptDisallowed() override = 0;

DISALLOW_COPY_AND_ASSIGN(SettingsPageUIHandler);

};